thisfro/pflaenz.li-Symfony
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases 3 Wiki Activity

Refactor Ddstance calculation #17

New issue
Closed
opened 2021-06-27 22:50:11 +02:00 by thisfro · 1 comment
thisfro commented 2021-06-27 22:50:11 +02:00
Owner
Copy link

The distance is calculated from one PLZ to another and they get converted to coordinates within src/Service/PlzToCoordinate.php directly.

This should probably be handled within a seperate service.

The result could look something like:

  • src/Service/PlzToCoordinate.php: only handles the conversion to a coordinate
  • src/Service/CalculateDistance.php: only handles the actual distance calculation

So #16 can use both independently

The distance is calculated from one PLZ to another and they get converted to coordinates within `src/Service/PlzToCoordinate.php` directly. This should probably be handled within a seperate service. The result could look something like: - `src/Service/PlzToCoordinate.php`: only handles the conversion to a coordinate - `src/Service/CalculateDistance.php`: only handles the actual distance calculation So #16 can use both independently
thisfro added this to the Basic functionality milestone 2021-06-27 22:50:11 +02:00
thisfro added the
Idea
Note
 labels 2021-06-27 22:50:12 +02:00
thisfro commented 2021-07-15 15:47:35 +02:00
Author
Owner
Copy link

This is actually already the case...

This is actually already the case...
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
master
cookie-consent-gdpr
translation
v0.0.3
0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
Bug

If something not works as intended

  
Deployment

Things that consider deployment

  
Design

Stuff that relates to design

  
Idea

To keep track of ideas

  
Note

Things to keep in mind

  
Security

Related to security issues

No labels
Bug
Deployment
Design
Idea
Note
Security
Milestone
Clear milestone
No items
No milestone
Basic functionality
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: thisfro/pflaenz.li-Symfony#17
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?